deps: upgrade polkadot 2412 #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| impl xcm_runtime_apis::dry_run::DryRunApi<Block, RuntimeCall, RuntimeEvent, OriginCaller> for Runtime { | ||
| fn dry_run_call(origin: OriginCaller, call: RuntimeCall) -> Result<CallDryRunEffects<RuntimeEvent>, XcmDryRunApiError> { | ||
| PolkadotXcm::dry_run_call::<Runtime, configs::xcm_config::XcmRouter, OriginCaller, RuntimeCall>(origin, call) | ||
| fn dry_run_call(origin: OriginCaller, call: RuntimeCall, result_xcms_version: Version) -> Result<CallDryRunEffects<RuntimeEvent>, XcmDryRunApiError> { |
Contributor
Author
There was a problem hiding this comment.
@TDemeco We talked about the XCM versioning and you recommended I fix it to v4. Should I enforce it here in the implementation ?
It doesn't look like we used it anywhere in the code base.
… set it empty because we are not using it (see paritytech/polkadot-sdk#5623)
…e biggest change regarding the TransactionExtension (see paritytech/polkadot-sdk#3685)
undercover-cactus
requested review from
TDemeco,
ffarall and
snowmead
and removed request for
snowmead
ffarall
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrade polkadot SDK from
stable24019tostable2412.Runtime changes :
sp_runtime::RuntimeStringand replace withCow<'static, str>orStringdepending on use case paritytech/polkadot-sdk#5693)RuntimeVerisontype and usesystem_versionto derive extrinsics rootStateVersioninstead ofV0paritytech/polkadot-sdk#4257)SelectCoredigest in Cumulus paritytech/polkadot-sdk#8153)TransactionExtensionas a replacement forSignedExtensionparitytech/polkadot-sdk#3685)TransactionExtensionas a replacement forSignedExtensionparitytech/polkadot-sdk#3685)Client changes :